kay, so it basically works on both x86 and 68k. however one thing is that after loading an archive the gui resizes to get some empty margin to the right. this looks strange. due to 68k being a slow system is also difficult to hit the buttons, because unarc is constantly busylooping refreshing the list. you have really to try hard pressing constantly the mouse button to get some response in between.

m68k nightly under winuae, i can attach exact config in case but doubt it matters. i will retest on 68k and x86 hosted asap.

Quote:

Unarc does seem to use NList, but I can't reproduce the bug in any case. I started Unarc on ABIv1 pc-i386 2015-12-08 nightly and opened an archive I found on the Icaros 2.0.3 DVD: print_s.lha. I clicked on the Start button and the files were extracted without any noticeable problems. What exact environment did you use?

Quote:
Fabulissimo !

Thank you very much for that ncafferkey, very much appreciated.

im not sure, i think its nlist(view?) in this case, but there seems to be a bug busy looping refreshing it.
testcase:
start unarc and choose some archive. i noticed it trying to decompress some lha on 68k, which was previously working.

The iconification bug should be fixed by SVN r51227. The list class was trying to be helpful by cleaning up images that hadn't been removed by the subclass, which didn't work out well when there wasn't actually a subclass.

@salass00:
:facepalm:

I was so much caught up into details that i completely overlooked that characteristic of fgets().

works like a charm.

Thank you.

Quote:

You don't need to scan the whole buffer. It's enough that you check the last character if it's a newline and set it to null-terminator if it is.

In C code it could look like:


Since FGets() stops reading when it encounters a newline you won't ever find one in the middle of a returned line.

@salass00
You're spot on

Of course, this excerpt was for illustration to show the difference in behavior on classic vs. AROS.

Removing the line-feeds would indeed solve the problem, but i ran into it in an attempt to read/display text-files.

In that program the text-file is 'pre-parsed' with FGetS(), thereby retrieving the file-offsets, add them to the ListView to be used as index numbers for the display routine. The display hook routine would seek the file using the passed offset and then read the line with FGetS(), to be returned for actual display.

So, would you suggest for me to scan the readbuffer (filled with FGetS() ) for line-feeds and remove them manually before returning them in my display hook ?

Which would also opt for adding some ifdefs for classic to 'inactivate' that line-feed removal part for classic, as things behave as intended there ?

@magorium

I don't know much about pascal but I would assume that the empty lines are because you add a new line to the end of all your strings (the "+ #10" part at the end). Remove that and I think it will be OK.