Re: BitMapScale() bug - the "desty" parameter is wrongly scaled [Bug Reports]

Forum Index

Board index » Development » Bug Reports » BitMapScale() bug - the "desty" parameter is wrongly scaled

Browsing this Thread: 1 Anonymous Users

Bottom

Previous Topic

Next Topic Register To Post

(1) 2 »

x303

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

#11

Just can't stay away

Thanks

Posted on: 2013/6/15 8:03

ncafferkey

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

#10

Home away from home

Quote:

x303 wrote:
Will there be a patch for the normal icaros build soon for those who don't run nightlys ?

Here you go.

Attach file:

Link only for registered users

Posted on: 2013/6/15 1:39

x303

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Just can't stay away

Will there be a patch for the normal icaros build soon for those who don't run nightlys ?

Posted on: 2013/6/14 11:14

magorium

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Home away from home

Quote:

ncafferkey wrote:
ScalePixelArray() is now implemented in ABI v1 and v0. It will appear in ABIv0 nightlies in the next day or two.

Magnifique ! Thanks you very much for that, and thank you for backporting at well.

Finally, i can get rid of my shoddy scaling routines \o/

Posted on: 2013/6/13 7:17

ncafferkey

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Home away from home

Quote:

magorium wrote:
@mazze:

not wanting to hijack this thread but since we're on the subject of scaling it took me almost half a day before i figured out that ScalePixelArray() was not implemented by looking at the sources. I mention this as you seem to be working on some of the documentation lately ?

ScalePixelArray() is now implemented in ABI v1 and v0. It will appear in ABIv0 nightlies in the next day or two.

Posted on: 2013/6/13 1:54

mazze

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Home away from home

It looks like desty was added twice to the row counter. Please test with next nightly build.

Posted on: 2013/1/17 21:16

AROS - Make code, not war :knuddel:

mazze

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Home away from home

Quote:

PortablE wrote:
As this is inside VMWare Player, I am using VESA.

On Linux/hosted with X11 driver I can reproduce the problem. I wrote a sample:


#include <proto/exec.h>

#include <proto/dos.h>

#include <proto/graphics.h>

#include <proto/intuition.h>



#include <graphics/gfxmacros.h>



#include <stdlib.h>

#include <stdio.h>



static struct Window *window;

static struct ColorMap *cm;

static struct RastPort *win_rp;



#define BMWIDTH (50)

#define BMHEIGHT (50)

struct BitMap *from_bm, *to_bm;

struct RastPort *bm_rp;



static LONG pen1=-1;

static LONG pen2=-1;



static void draw_bitmap(void);

static void clean_exit(CONST_STRPTR s);

static void handle_events(void);



int main(void)

{

    window = OpenWindowTags(NULL,

        WA_Left,   50,

        WA_Top,    70,

        WA_Width,  400,

        WA_Height, 350,

    

        WA_Title,         "Bitmap Graphics",

        WA_Activate,      TRUE,

        WA_SmartRefresh,  TRUE,

        WA_NoCareRefresh, TRUE,

        WA_GimmeZeroZero, TRUE,

        WA_CloseGadget,   TRUE,

        WA_DragBar,       TRUE,

        WA_DepthGadget,   TRUE,

        WA_IDCMP,         IDCMP_CLOSEWINDOW,

        TAG_END);

    

    if (! window) clean_exit("Can't open windown");

    

    win_rp = window->RPort;

    cm = window->WScreen->ViewPort.ColorMap;



    pen1 = ObtainBestPen(cm, 0xFFFF0000 , 0 , 0 , TAG_END);

    pen2 = ObtainBestPen(cm, 0 , 0 , 0xFFFF0000 , TAG_END);

    if ( !pen1 || !pen2) clean_exit("Can't allocate penn");

    

    draw_bitmap();

    handle_events();



    clean_exit(NULL);



    return 0;

}





static void draw_bitmap(void)

{

    UWORD depth = GetBitMapAttr(win_rp->BitMap, BMA_DEPTH);



    from_bm = AllocBitMap(BMWIDTH , BMHEIGHT, depth, BMF_MINPLANES, win_rp->BitMap);

    if (!from_bm) clean_exit("Can't allocate bitmapn");



    to_bm = AllocBitMap(BMWIDTH , 200, 200, BMF_MINPLANES, win_rp->BitMap);

    if (!to_bm) clean_exit("Can't allocate bitmapn");

    

    bm_rp = CreateRastPort();

    if (!bm_rp) clean_exit("Can't allocate rastport!n");

    bm_rp->BitMap = from_bm;



    SetRast(bm_rp, 0);

    SetAPen(bm_rp, pen1);

    DrawCircle(bm_rp, 24, 24, 24);

    SetAPen(bm_rp, pen2);

    Move(bm_rp, 0, 0);

    Draw(bm_rp, 49, 49);

    Move(bm_rp, 49, 0);

    Draw(bm_rp, 0, 49);

    Draw(bm_rp, 49, 49);

    Draw(bm_rp, 49, 0);

    Draw(bm_rp, 0, 0);

    Draw(bm_rp, 0, 49);



    struct BitScaleArgs bsa = {

        0, 0, // UWORD   bsa_SrcX, bsa_SrcY;                    /* source origin */

        50, 50, // UWORD   bsa_SrcWidth, bsa_SrcHeight;         /* source size */

        1, 1, // UWORD   bsa_XSrcFactor, bsa_YSrcFactor;        /* scale factor denominators */

        20, 20, // UWORD   bsa_DestX, bsa_DestY;                  /* destination origin */

        0, 0, // UWORD   bsa_DestWidth, bsa_DestHeight;         /* destination size result */

        1, 1, // UWORD   bsa_XDestFactor, bsa_YDestFactor;      /* scale factor numerators */

        from_bm, // struct BitMap *bsa_SrcBitMap;               /* source BitMap */

        to_bm, // struct BitMap *bsa_DestBitMap;                /* destination BitMap */

        0, // ULONG   bsa_Flags;                                /* reserved.  Must be zero! */

        0, // UWORD   bsa_XDDA, bsa_YDDA;                       /* reserved */

        0, // LONG    bsa_Reserved1;

        0 // LONG    bsa_Reserved2;

    };



    ClipBlit(bm_rp, 0, 0, win_rp, 0, 0, BMWIDTH, BMHEIGHT, 0xC0);



    bm_rp->BitMap = to_bm;

    SetRast(bm_rp, 0);



    BitMapScale(&bsa);



    ClipBlit(bm_rp, 0, 0, win_rp, 0, 50, BMWIDTH, BMHEIGHT, 0xC0);

    ClipBlit(bm_rp, 0, 0, win_rp, 50, 0, BMWIDTH, BMHEIGHT, 0xC0);

}





static void handle_events(void)

{

    struct IntuiMessage *imsg;

    struct MsgPort *port = window->UserPort;

    BOOL terminated = FALSE;

        

    while (!terminated)

    {

        Wait(1L << port->mp_SigBit);

        if ((imsg = (struct IntuiMessage *)GetMsg(port)) != NULL)

        {

            switch (imsg->Class)

            {

                case IDCMP_CLOSEWINDOW:

                    terminated = TRUE;

                    break;

            }

            ReplyMsg((struct Message *)imsg);

        }

    }

}





static void clean_exit(CONST_STRPTR s)

{

    if (s) PutStr(s);



    // Give back allocated resourses

    if (from_bm) FreeBitMap(from_bm);

    if (to_bm) FreeBitMap(to_bm);

    if (bm_rp) FreeRastPort(bm_rp);

    if (pen1 != -1) ReleasePen(cm, pen1);

    if (pen2 != -1) ReleasePen(cm, pen2);

    if (window) CloseWindow(window);



    exit(0);

}

Even with scaler fraction set to 1:1 there is a difference between x and y shift.

Edit: problem is reproducible on both ABIv1 and v0.

Attach file:

(0.00 KB)

Posted on: 2013/1/17 19:55

AROS - Make code, not war :knuddel:

magorium

Re: BitMapScale() bug - the "desty" parameter is wrongly scaled

Home away from home

@mazze:

not wanting to hijack this thread but since we're on the subject of scaling it took me almost half a day before i figured out that ScalePixelArray() was not implemented by looking at the sources. I mention this as you seem to be working on some of the documentation lately ?

Posted on: 2013/1/17 19:02