Browsing this Thread:
1 Anonymous Users
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
 
|
Quote:
Edit: I have adjusted this post somewhat -: FWIW - Personally I dont think Decoration belongs in C: anyhow. It should be moved somewhere like SYS:System/. I would rename it to just Decor which is much more indicative of its use than Decoration (which always makes mu just think of christmas decor). I would remove the assign requirement completely, and store the current theme in the Decor applications icon tooltypes. The application would create the assign at runtime. One thought was to handle decor as a package in itself, however if the assign requirement is no longer necessary it could be just a typical app launchable from WBStartup. I would also think the actual handling of the theme gfx elements would be better in a shared resource (e.g. library) that decoration and the prefs app utilized - rather than the prefs trying to duplicate the code as is currently the case. This would also make it much easier for 3rd party code to share the theme'ing. The Theme descriptor I would redo using something like XML so that it is easier to parse using share-able code, and easier to work with in 3rd party applications for the same reason (e.g. a theme editor).
Posted on: 2014/11/13 23:31
Edited by Kalamatee on 2014/11/14 0:33:17
|
|||
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
Hi Neil, removing the env var or renaming it should disable decoration still - though themes with missing imagery should never have worked. p.s. - the theme'ing changes themselves are only to expose a boopsi container in the screen title that can be hooked into, and to address some inefficiencies in how decoration renders (+ a few off-by-1 errors in the rendering code). If a theme doesn't support the title changes there should be no difference, except needing some minor corrections to co-ord's.
Posted on: 2014/11/13 18:39
|
|||
|
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
@Kalamatee
With the latest theming changes, is it possible to disable decoration other than by preventing C:Decoration from running? Themes with only partial imagery don't seem to work anymore (e.g. os3.1).
Posted on: 2014/11/13 18:16
|
|||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
Mostly prefs apps and such. AFAIR it is almost exclusively Zune apps though, so A good solution might be to write some class which handles the translation (e.g. it has a load of "standard" gadget icons, and if a theme is used which replaces them, will utilize that imagery instead).
Posted on: 2014/11/13 16:43
|
|||
|
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Today's ABIv0 NB includes some new themes that weren't in old ones, including AROSDefault. I've given a look but I guess they are all using the same default png image for the 'iconify' button. They work, but the not-coherent iconify gadget makes them really ugly to see. BTW, selecting Special and Mason still creates problems to AROS at startup. I will leave things as they are in Icaros for the moment.
@Kalamatee you're right, nothing changes, my proposal was there just to save some lines in the script and to include all required actions for decorations in a single passage. BTW, when you're talking about GUIs with hardcoded paths, what kind of GUIs are you talking about? 3rd party applications? themes? AROS programs? I'm currently trying to understand why sometimes the "Parent" button at the right of path field in Wanderer disappears. In particular, I have this issue with 68K Wanderer and I couldn't find a solution yet. kind regards
Posted on: 2014/11/13 11:32
|
|||
|
p.bes
Icaros Desktop AROS distribution mantainer |
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
Really? My bad then. I didn't have a look indeed, though I recall more ancient times when removing the var would not be satisfactory (the decoration was then defeated OK, but between other things Wanderer windows lacked the "up" button). Since then I prefer to comment out C:Decoration in S:Startup-Sequence and I confess I didn't really come to it any more. But I know it's a way that can't be recommended, hence my vote for considering Paolone's solution if he got it working correctly. Now I guess the ArosDefault theme aims at solving the problem I just mentioned ("up" button).
Posted on: 2014/11/13 8:45
|
|||
|
Everyone knew it was impossible. Along came a fool who did not know and he did it.
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
The mistake is not in the code block, but in that you have not copied the AROSDefault theme that existed in the branch where this change was made. The THEME: assign is needed because some GUI's have hard coded paths to icons that reside within the THEME: assign, and removing it therefore breaks those GUI's.
Posted on: 2014/11/13 8:17
|
|||
|
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
The "proposed" change makes absolutely no difference in this respect.
Posted on: 2014/11/13 8:12
|
|||
|
|
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
Quote:
IIRC, there have also been a recent change in ABIv1 themes structure or directory placing that would have prevented old themeing to work with new themes, but I can be really wrong here. That's why the topic has been delayed for now (after all, we had fixed far more urgent things in Icaros for 2.0 release). I should study how themes work in ABIv1. In any case, please keep my proposal under consideration.
Posted on: 2014/11/12 9:25
|
|||
|
p.bes
Icaros Desktop AROS distribution mantainer |
||||
|
||||
|
Re: About themes and startup-sequence
|
||||
|---|---|---|---|---|
|
Home away from home
|
I do like your proposal Paolone, especially the fact that removing the var would disable decoration. It's just logic indeed.
Posted on: 2014/11/11 21:48
|
|||
|
Everyone knew it was impossible. Along came a fool who did not know and he did it.
|
||||
|
||||
You can view topic.
You cannot start a new topic.
You cannot reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You cannot post without approval.
You cannot use topic type.
You cannot use HTML syntax.
You cannot use signature.
You cannot create PDF files.
You cannot get print page.
