Re: Default Icon Action [Icaros Desktop]

Forum Index

Board index » Miscellaneous Forums » Icaros Desktop » Default Icon Action

Browsing this Thread: 1 Anonymous Users

Bottom

Previous Topic

Next Topic Register To Post

« 1 (2) 3 4 5 ... 10 »

magorium

Re: Default Icon Action

#86

Home away from home

Quote:

Absolutely, this are going to be the default tooltyp for def_projecticons...

The thing i will use it mostly for os indeed to load datafiles into tools. I was sick'n'tired writing iconX scripts for those :/

Quote:

if one wish to have icons that override this behaviour, it is as simple as make an icon->info on the project itself, remove the default-tool to proper one and save then you got a local copy.

exactly

Quote:

Then automagically you got an info just for that file that works exactly as one needed (yet another feature that differs to the better from Amiga)

Isn't amigaOS great ?

Quote:

So thanks yet again... I think this is needed... everybody want's it, they just don't know's it yet!

That's the problem with these things. No-one seems to realize (but you ofcourse)

How much time you think it will take for some-one to realize that he/she can pass any file this way to a script that checks for file-extension and then act accordingly ? :angel4:

have fun !

Posted on: 2014/3/1 18:33

azvareth

Re: Default Icon Action

#85

Home away from home

Quote:

Hopefully you are able to enjoy it

Absolutely, this are going to be the default tooltyp for def_projecticons...

if one wish to have icons that override this behaviour, it is as simple as make an icon->info on the project itself, remove the default-tool to proper one and save then you got a local copy.

Then automagically you got an info just for that file that works exactly as one needed (yet another feature that differs to the better from Amiga)

So thanks yet again... I think this is needed... everybody want's it, they just don't know's it yet

//Edit
btw: one improvement... but not necessary

if a special key shift|ctrl|amiga|none key could be passed along with for example a {k} param that would be nice as well

Reason one could have a run default action when no special key is selected but when special key IS selected a ReqChoice menu could be executed allowing for selecting what tool to use...

Posted on: 2014/3/1 18:21

magorium

Re: Default Icon Action

#84

Home away from home

Quote:

So! here is the sashimi output

great !

thank you very much for that. I really wanted to see that with my own eyes (as it showed this on my setup as well

).

Quote:

with my examplescrip (runWith.bat" It works on a one file click allowing me to edit or run the script (or cancel the action), on multiselect itt allow me to push files onto the editor - but run the last script if I wish to...

Ofcourse, you did all the hard work with the scripts.

Quote:

So! good work... time for a real release?

Yups, if no other issues pop-up.

It now works for both original 1.5.2 and icaros 1.5.2 WiP5 (and exactly the same, so no recompilation needed).

I'll make no other changes, other then stripping the v006 alpha 2 executable that you tested and rename it into v006 beta. So if you want you can keep that alpha version (and strip yourself: strip name_of_executable --strip-uneeded).

I will fix some typos in the documentation, package it and upload it to the archives.

I have taken a look at the key-thing. I have an unanswered question about keyboard.device. I think i need it to be able to read the status of the keys. So unfortunately that is on hold for the moment.

If you (or anyone else for that matter) want other features then let me know. Now that the base is working....

thank you very much for all your testing and feedback azvareth :thumbsup:. i could not have finished it properly without it.

Hopefully you are able to enjoy it

Quote:

ooops: bugs...

but this is textbug...

in wbXcli readme

example: WBXCLI=lua:lua "%F"

See bold written text ;-p

Posted on: 2014/3/1 18:13

azvareth

Re: Default Icon Action

#83

Home away from home

with my examplescrip (runWith.bat" It works on a one file click allowing me to edit or run the script (or cancel the action), on multiselect itt allow me to push files onto the editor - but run the last script if I wish to...

So! good work... time for a real release?

ooops: bugs...

but this is textbug...

in wbXcli readme

example: WBXCLI=lua:lua "%F"

Posted on: 2014/3/1 18:00

azvareth

Re: Default Icon Action

#82

Home away from home

Ok!

Fast and quik answer of one testrun...

IO-put from wbXcli seems to be ok! the paths is correct.

So! here is the sashimi output

Quote:

[wbXcli] enter
[wbXcli] Attempting to process 3 icons
[wbXcli] (1)
[wbXcli] (1) retrieved argument -> "echo.lua"
[wbXcli] (1) retrieved filename from lock -> "echo.lua"
[wbXcli] (1) retrieved directory from lock -> "Work:Development/Lua/test/"
[wbXcli] (1) trying to get icon for file "Work:Development/Lua/test/echo.lua"
[wbXcli] (1) could not find physical icon for file "Work:Development/Lua/test/echo.lua"
[wbXcli] (1) try falling back to default icon
[wbXcli] (1) found icon for file "Work:Development/Lua/test/echo.lua"
[wbXcli] (1) the icon is a project icon, parsing the icon follows
[wbXcli] (1) tool type WINDOW was not found
[wbXcli] (1) tool type STACK was not found
[wbXcli] (1) tool type USERSHELL was not found
[wbXcli] (1) tool type WAIT was not found
[wbXcli] (1) tool type DELAY was not found
[wbXcli] (1) tool type WBXCLI found (= run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "{f}")
[wbXcli] (1) INFO: wait 100 stack 40960 usershell -1 window CON:0/50//80/wbXcli/Auto
[wbXcli] (1) WBXCLI.command = run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "Work:Development/Lua/test/echo.lua"
[wbXcli] (1) console window opened ok
[Shell] substArgs: iLevel -> 2
[Shell] substArgs: sName -> Work:Development/Lua/test/echo.lua
[wbXcli] (1) SystemTags() returned
[wbXcli] (1) Performing wait
[wbXcli] (1) Closing con window
[wbXcli] (1) Executed command returned with value 0.
[wbXcli] (1) Finished handling this argument
[wbXcli] (1)
[wbXcli] (2)
[wbXcli] (2) retrieved argument -> "Work:Development/Lua/hello.lua"
[wbXcli] (2) retrieved filename from lock -> "hello.lua"
[wbXcli] (2) retrieved directory from lock -> "Work:Development/Lua/"
[wbXcli] (2) trying to get icon for file "Work:Development/Lua/hello.lua"
[wbXcli] (2) could not find physical icon for file "Work:Development/Lua/hello.lua"
[wbXcli] (2) try falling back to default icon
[wbXcli] (2) found icon for file "Work:Development/Lua/hello.lua"
[wbXcli] (2) the icon is a project icon, parsing the icon follows
[wbXcli] (2) tool type WINDOW was not found
[wbXcli] (2) tool type STACK was not found
[wbXcli] (2) tool type USERSHELL was not found
[wbXcli] (2) tool type WAIT was not found
[wbXcli] (2) tool type DELAY was not found
[wbXcli] (2) tool type WBXCLI found (= run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "{f}")
[wbXcli] (2) INFO: wait 100 stack 40960 usershell -1 window CON:0/50//80/wbXcli/Auto
[wbXcli] (2) WBXCLI.command = run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "Work:Development/Lua/hello.lua"
[wbXcli] (2) console window opened ok
[Shell] substArgs: iLevel -> 2
[Shell] substArgs: sName -> Work:Development/Lua/hello.lua
[wbXcli] (2) SystemTags() returned
[wbXcli] (2) Performing wait
[wbXcli] (2) Closing con window
[wbXcli] (2) Executed command returned with value 0.
[wbXcli] (2) Finished handling this argument
[wbXcli] (2)
[wbXcli] (3)
[wbXcli] (3) retrieved argument -> "Work:Development/env.lua"
[wbXcli] (3) retrieved filename from lock -> "env.lua"
[wbXcli] (3) retrieved directory from lock -> "Work:Development/"
[wbXcli] (3) trying to get icon for file "Work:Development/env.lua"
[wbXcli] (3) could not find physical icon for file "Work:Development/env.lua"
[wbXcli] (3) try falling back to default icon
[wbXcli] (3) found icon for file "Work:Development/env.lua"
[wbXcli] (3) the icon is a project icon, parsing the icon follows
[wbXcli] (3) tool type WINDOW was not found
[wbXcli] (3) tool type STACK was not found
[wbXcli] (3) tool type USERSHELL was not found
[wbXcli] (3) tool type WAIT was not found
[wbXcli] (3) tool type DELAY was not found
[wbXcli] (3) tool type WBXCLI found (= run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "{f}")
[wbXcli] (3) INFO: wait 100 stack 40960 usershell -1 window CON:0/50//80/wbXcli/Auto
[wbXcli] (3) WBXCLI.command = run execute s:runWith.bat `RequestChoice TITLE="Lua starter" BODY="What do you like to do?" GADGETS="EDIT|NOTHING|RUN"` "Work:Development/env.lua"
[wbXcli] (3) console window opened ok
[Shell] substArgs: iLevel -> 2
[Shell] substArgs: sName -> Work:Development/env.lua
[wbXcli] (3) SystemTags() returned
[wbXcli] (3) Performing wait
[wbXcli] (3) Closing con window
[wbXcli] (3) Executed command returned with value 0.
[wbXcli] (3) Finished handling this argument
[wbXcli] (3)
[wbXcli] leave
Sashimi installed ([Ctrl]+C or "Break 1" to remove)
Sashimi removed.

Posted on: 2014/3/1 17:51

magorium

Re: Default Icon Action

#81

Home away from home

Could you try this executable azvareth ?

I would be oblidged if you could also show debug-output, but if it works then that isn't a priority.

Please lemme at least know if it works for you or not.

File only contains the alpha2 executable, just rename it to wbXcli and replace your current (installed) one.

:fingers crossed:

red: file removed, because of a new version, see here.

Posted on: 2014/3/1 15:33

Edited by magorium on 2014/5/18 17:10:59

magorium

Re: Default Icon Action

#80

Home away from home

Quote:

Could you test if lock works as it should...

it simply doesn't

Quote:

I think but I may be wrong, that I read a lock must be done when CD is in the dir where lock is supposed to take place

where do you think the currentdir() function is for ?

The problem is, it does this for the lock. But that lock is wrong to begin with, ergo it changes to the wrong directory.

Quote:

thinking like this: if CD is sub dir and a lock is attempted on parent dir... the lock gets nil and name get full dir..

IF CD is parent dir then lock perhaps work, the wa_lock becomes perhaps correct and name has no pathpart...

guessing, still not reading any API's...

according to RKRM:
Quote:

If your program was started through extended select, then you get one WBArg for each icon in the selected group in the order they were selected.
The wa_Name field contains the file name corresponding to each icon unless the icon is for a directory, disk, or the Trashcan in which case the wa_Name is set to NULL. The wa_Lock field contains an AmigaDOS Lock on the directory where the file is stored. (For disk or drawer icons the
wa_Lock is a lock on the directory represented by the icon. Or, wa_Lock may be NULL if the icon type does not support locks.)

Despite the fact that AmigaMail (dospackets) state that the name _may_ contain a path-part, the quote is clear. Thereby, i am not allowed to look into the lock structure myself.

It seems the solution iconX uses works. very strange. i need to add some stuff, and shall zip up a new executable and post it.

Posted on: 2014/3/1 14:37

azvareth

Re: Default Icon Action

#79

Home away from home

Could you test if lock works as it should...

I think but I may be wrong, that I read a lock must be done when CD is in the dir where lock is supposed to take place

thinking like this: if CD is sub dir and a lock is attempted on parent dir... the lock gets nil and name get full dir..

IF CD is parent dir then lock perhaps work, the wa_lock becomes perhaps correct and name has no pathpart...

guessing, still not reading any API's...

Posted on: 2014/3/1 13:22

magorium

Re: Default Icon Action

#78

Home away from home

ah, yes azvareth.

the problem is as follows:
- WBArgs are pushed to me.
- Each WbArg has a wa_lock and a wa_name
- wa_lock _should_ contain the directoy where wa_name lives (but proofed to be not).
- wa_name contains the name-part of the file.

It _looks_ like when the lock is wrong in wa_lock field then the wa_name contains the _full_ path
to the file (ergo including directory).

Now the 'problem' with a simple check: if wa_name contains a path is that i have no way of knowing if the wa_name is indeed actually a file. It could also be a directory, or a volume, or a kickstart or otherwise.

Ofcourse, some of that is solvable in a jiffy (somewhat pseudo):


begin

  ThisLock := ActiveWbArg^.wa_lock;

  ThisName := ActiveWBArg^.wa_name;



  if ContainsFullPath(ThisName) then

  begin

    if isDirectory(ThisName) then

    begin

      { do nothing, we need to skip this argument alltogether }

      LockIsDirectroy := true;

    end

    else

    begin

      DirectoryString := ExtractFilePath(ThisName);

      FileName        := ExtractFileName(ThisName);

    end;

  end

  else

  begin

    DirectoryString := NameFromLock(ThisLock);

    FileName        := ThisName;

  end;



  If Not LockIsDirectory then

  begin

     RealFullFileName := IncludeTrailingPathDelimiter(DirectroyString) + FileName;

     Icon := GetDiskObject(RealFullFileName);

     blah_di_blah_rest;

  end;

end;

But that code is ugly as hell, even more when all checks are implemented.

So i am trying to find a (more elegant) solution that can give me the proper lock, of the actual directory that the file resides in.

There is also a solution given in the RKRM (or mail-archives, not sure), which does a open and getting the real filename from the fileinfoblock using examine(). That's even more uglier :/

So i am investigating OS functionality that can give a bit of a hand in a more proper way. But that means a lot of testing

Just so that you know, it works perfectly over here, including skipping all files/icons that are not a project-icon (as i already implemented a solution). And i have no idea why it seems to fail on regular 1.5.2.

Posted on: 2014/3/1 12:04

azvareth

Re: Default Icon Action

#77

Home away from home

I am not sure exactly how stuff works or the names as I currently is not viewing any API refs, but assume that WB lock to first icon... Then passing all other icons as args.

VERY PSEUDO:


FLIST: ARRAY;



PROC: Main;

var

  i: Integer;

  s,d: string;

  l,o: Object;

  

Begin

  IF wbArgs.length > 0 Then

  Begin

    FLIST.Push(pathWbArgsFromFirstLock);

    IF wbArgs.Length > 1 Then

    Begin

      FOR i:=1 TO wbArgs.length-1 DO

      Begin

        S:=wbarg[i].filePathFromArg;

        IF FileExists(S) Then FLIST.Push(S) Else WriteLn('ErrArgs got '+S);

      End;

    End;

  End;



  // process Icon in FList;

  For i:=0 TO FLIST.length-1 DO

  BEGIN

    d:=CDTO(PathPart(FLIST[i]));

    l:=Lock(filePart(FLIST[i]));

    o:=GetDiskObjectFromLock(l);

       Examine and process icondata

    FreeDiskObjectFromLock(o);

    FreeLock(l);

    d:=CDTO(d);

  END;



END;

That means, first fix all paths, check if they exists... if so then continue to process paths with icon files... if no iconfile exists try default icon.

NOTE this is a very rough PSEUDO...

Posted on: 2014/3/1 11:35