Re: What could i be doing wrong? [Development (General)]

Forum Index

Board index » Development » Development (General) » What could i be doing wrong?

Browsing this Thread: 1 Anonymous Users

Bottom

Previous Topic

Next Topic Register To Post

Kalamatee

Re: What could i be doing wrong?

#10

Home away from home

Yep! That was exactly the problem - Hurray!

http://aros-exec.org/modules/xcgal/displayimage.php?pid=127&pos=-127

Posted on: 2006/4/18 23:20

Georg

Re: What could i be doing wrong?

Home away from home

Quote:

Do you have any idea what might be giving the displayed image a blue tinge? (try demos-old/morph3d)

As it is at the moment the cgfx pixfmts and rectfmt ids in AROS have their names based on component access, not pixel access. So to say. This means that RECTFMT_ARGB in memory is always 0xAA 0xRR 0xGG 0xBB. No matter if you are running on big endian or little endian machine. If on a little machine you write a ULONG which is 0xAARRGGBB to memory it will end up as 0xBB 0xGG 0xRR 0xAA in memory.

So for pixel accesses you would have to change code to use RECTFMT_ARGB only on big endian machines while on little endian machine you would use RECTFMT_BGRA32.

As an alternative I have been thinking since a while to modify cybergraphics header to optionally switch meaning of pixfmt/rectfmt ids to be pixel based. Then for code using pixel accesses you could always use RECTFMT_ARGB: ~


#define CGX_PIXELBASED_FORMAT_IDS

#include <libraries/cybergraphics.h>

Posted on: 2006/4/18 21:46

Kalamatee

Re: What could i be doing wrong?

Home away from home

Thanks again Georg,

I'll update the code soon and commit the newer version to SVN for your perusal =D

Mesa 3.4.2 contains functions to set mesa's internal rendering area within the buffers - i dont make use of them atm though i plan to at some time.

Do you have any idea what might be giving the displayed image a blue tinge? (try demos-old/morph3d)

Posted on: 2006/4/18 17:38

Edited by Kalamatee on 2006/4/18 18:00:48
Edited by Kalamatee on 2006/4/18 18:06:20

Georg

Re: What could i be doing wrong?

Home away from home

overpainting window border:

don't use window->RPort, but make a clone of it with CloneRastPort() (free with FreeRastPort()) and tell
it to clip to the inside of the borders (AROS only feature):


struct Rectangle rect;



struct TagItem rptags[] =

{

    {RPTAG_ClipRectangle        , (IPTR)&rect                       },

    {RPTAG_ClipRectangleFlags    , (RPCRF_RELRIGHT | RPCRF_RELBOTTOM)},

    {TAG_DONE                                                        }

};



rect.MinX = win->BorderLeft;

rect.MinY = win->BorderTop;

rect.MaxX = -win->BorderRight;

rect.MaxY = -win->BorderBottom;



SetRPAttrsA(rp, rptags);

Posted on: 2006/4/18 11:24

Georg

Re: What could i be doing wrong?

Home away from home

aros8bit_Standard_resize() has same error.

Posted on: 2006/4/18 11:17

Georg

Re: What could i be doing wrong?

Home away from home

window resizing (arosTC_Standard_resize()):


if (amesa->visual->db_flag)

{

    if (amesa->back_rp) destroy_rastport(amesa->back_rp); /* Free double buffer */

-   if((amesa->back_rp = make_rastport(amesa->RealWidth,amesa->RealHeight,amesa->depth,amesa->rp->BitMap))==NULL) {

+   if((amesa->back_rp = make_rastport(amesa->RealWidth,amesa->RealHeight,amesa->depth,amesa->front_rp->BitMap))==NULL) {

        amesa->rp = amesa->front_rp;

        printf("AROSMesa Error : To little mem free. Couldn't allocate Dubblebuffer in this size.n");

    }

    else amesa->rp=amesa->back_rp;

}

amesa->back_rp and amesa->rp can point to same rastport, so after destroying amesa->back_rp, amesa->rp->BitMap is not valid anymore.

Posted on: 2006/4/18 11:15

Kalamatee

Re: What could i be doing wrong?

Home away from home

Well, ive managed to fix the initial crashing however theres still issues causing it to crash (and some visual errors).

http://aros-exec.org/modules/xcgal/displayimage.php?pid=125&pos=-125

Mazze: ive aaltered the rastport allocation already when i started reworking the aros rasterizer.

Georg: thanx for the info - atm im mostly working on the true color functionality.

Posted on: 2006/4/17 21:26

Georg

Re: What could i be doing wrong?

Home away from home

AROSMesa_8bit.c:


void AllocOneLine( struct arosmesa_context *c) {

    if(c->imageline) FreeVec(c->imageline);

    if (c->depth<=8)

    {

        c->imageline = AllocVec((c->width+15) & 0xfffffff0,MEMF_ANY);   /* One Line */

    } else {

-       c->imageline = AllocVec(((c->width+3) & 0xfffffff0)*4,MEMF_ANY);   /* One Line */

+       c->imageline = AllocVec(((c->width+3) & 0xfffffffc)*4,MEMF_ANY);   /* One Line */

    }

}

And some demos need more than default stack.

Posted on: 2006/4/17 21:20

mazze

Re: What could i be doing wrong?

Home away from home

Just an idea (I haven't looked in the mesa source): Under AROS you need special functions/macros to clone a rastport.
Click: Rastport cloning

Posted on: 2006/4/17 19:29

AROS - Make code, not war :knuddel:

Kalamatee

What could i be doing wrong?

Home away from home

Hi!

Ive spent the last week merging the svn mesa port with Mesa 3.4.2, but im having some sticky problems and was wondering if anyone might have a clue what im doing wrong...

Basically the problem is this -

I have 2 functions which reside in seperate files,

AROSMesaCreateContext(), and arosTC_Standard_Init()

AROSMesaCreateContext creates an internal context structure, and stores the used rastports pointer in it.

It then calls arosTC_Standard_Init, and my debug output shows the correct address for the context - however data in it has now become corrupt/dissappeared ...

In particular the rastport pointer is now NULL which I cant understand.

I can tell from the debug output the values are correctly stored in the context prior to calling arosTC's func, however its all corrupt after calling it.

HELP!?!?!?!

Posted on: 2006/4/17 18:24