Re: Yannick's work [General chat]

Forum Index

Board index » AROS-Exec forums » General chat » Yannick's work

Browsing this Thread: 1 Anonymous Users

Bottom

Previous Topic

Next Topic Register To Post

« 1 2 3 (4) 5 6 7 ... 113 »

wawa

Re: Yannick's work

#1095

Home away from home

we have yet another typo: mcc_PictDisp.h should be mcc_Pictdisp.h

Quote:

Compile failed: /home/wawa/aros-x86-464/bin/linux-i386/tools/crosstools/i386-aros-gcc -iquote /home/wawa/aros-x86-464/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/ -iquote /home/wawa/AROS-source/AROS/ports/graphics/zuneview -iquote . -m32 -march=i486 -O2 -Wall -Werror -Wno-pointer-sign -Wno-parentheses -DZUNEVIEW -DAROS_ABI_V1 -fno-ipa-cp -I/home/wawa/aros-x86-464/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src -DAROS_BUILD_TYPE=AROS_BUILD_TYPE_PERSONAL -D__SRCFILENAME__="bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_Paint.c" -c /home/wawa/aros-x86-464/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_Paint.c -o /home/wawa/aros-x86-464/bin/pc-i386/gen/ports/graphics/zuneview/Picture_Paint.o
/home/wawa/aros-x86-464/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_Paint.c:28:26: fatal error: mcc_PictDisp.h: No such file or directory
compilation terminated.
mmakefile:407: recipe for target '/home/wawa/aros-x86-464/bin/pc-i386/gen/ports/graphics/zuneview/Picture_Paint.o' failed

Posted on: 2018/7/25 19:26

Yannickescu

Re: Yannick's work

#1094

Home away from home

I've just uploaded archives with corrections
As there were no functional changes the file name hasn't changed, you should however update the diff files in AROS port repository

A quick test showed me that ZuneView might notwork anymore on AB1v1 64bit, I didn't find the issue that appears to be in Win_icons.c

I have to update my old virtualbo install of ABIv1 64bit also before confirming that there's actually an issue with ZuneView. ZunePaint was working.

Posted on: 2018/7/25 18:03

Edited by Yannickescu on 2018/7/25 18:24:01
Edited by Yannickescu on 2018/7/25 18:26:17

Yannick
http://www.dusabledanslherbe.eu/AROSPage

wawa

Re: Yannick's work

#1093

Home away from home

analogically:
Quote:

/home/wawa/aros-x86-810/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/SupportFunctions.c:214:44: error: '%s' directive writing up to 127 bytes into a region of size 126 [-Werror=format-overflow=]
sprintf((char *)dispvol, "\033b%s", vol);
^~ ~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/SupportFunctions.c:214:13: note: 'sprintf' output between 3 and 130 bytes into a destination of size 128
sprintf((char *)dispvol, "\033b%s", vol);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/SupportFunctions.c:232:48: error: '%s' directive writing up to 127 bytes into a region of size 126 [-Werror=format-overflow=]
sprintf((char *)dispvol, "\033b%s", vol);
^~ ~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/SupportFunctions.c:232:17: note: 'sprintf' output between 3 and 130 bytes into a destination of size 128
sprintf((char *)dispvol, "\033b%s", vol);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

can you send me your fixes to supportfunctions in order to check further, as i cant see any new commits in your repo.

Posted on: 2018/7/25 12:15

Yannickescu

Re: Yannick's work

#1092

Home away from home

I believe the color issue on BE systems will be corrected with tonight's commit.

There is one part about pointers that I'm not sure and might require some fiddling in "pointers.h"

I've tried to correct all issues you where pointing out up to now, if there are any more it might be useful if you can provide a log from the compilation.

I can't install a new development environment at the moment, I'm moving next week and most of my stuff is already packed.

Posted on: 2018/7/25 11:22

Yannick
http://www.dusabledanslherbe.eu/AROSPage

wawa

Re: Yannick's work

#1091

Home away from home

what concerns 8.1.0, here we go right away, as example:

Quote:

/home/wawa/aros-x86-810/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/SupportFunctions.c: In function 'GetVolList':
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/SupportFunctions.c:214:44: error: '%s' directive writing up to 127 bytes into a region of size 126 [-Werror=format-overflow=]
sprintf((char *)dispvol, "\033b%s", vol);
^~ ~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/SupportFunctions.c:214:13: note: 'sprintf' output between 3 and 130 bytes into a destination of size 128
sprintf((char *)dispvol, "\033b%s", vol);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/SupportFunctions.c:232:48: error: '%s' directive writing up to 127 bytes into a region of size 126 [-Werror=format-overflow=]
sprintf((char *)dispvol, "\033b%s", vol);
^~ ~~~
/home/wawa/aros-x86-810/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/SupportFunctions.c:232:17: note: 'sprintf' output between 3 and 130 bytes into a destination of size 128
sprintf((char *)dispvol, "\033b%s", vol);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

These kind of issues are pretty common with 8.1.0 and aros sources.

Posted on: 2018/7/25 9:28

wawa

Re: Yannick's work

#1090

Home away from home

Quote:

Yannickescu wrote:

@Wawa, can you tell me where you've seen the warning about indentation?

this warning is 6.3.0 exclusive. i could perhaps try with 8.1.0 to see iff there is any further complaints. zunepaint:

Quote:

/home/wawa/aros-x86-630/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/Picture_IO.c:165:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
else
^~~~
/home/wawa/aros-x86-630/bin/pc-i386/Ports/zunepaint/ZunePaint_v0.13/ZunePaint/src/Picture_IO.c:172:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
if (DTImage)
^~

zuneview:

Quote:

/home/wawa/aros-x86-630/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_IO.c: In function 'exportDATATYPE':
/home/wawa/aros-x86-630/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_IO.c:165:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
else
^~~~
/home/wawa/aros-x86-630/bin/pc-i386/Ports/zuneview/ZuneView_v0.39/ZuneView/src/Picture_IO.c:172:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
if (DTImage)
^~

do you think you would be able to find the issue with wrong colors of these buttons on big endian i wrote earlier?

btw i need to remember i forgot to enable ppc build fo these apps. alos i see x86_64 fas bee disabled. can anyone compile and test on this platform?

Posted on: 2018/7/25 9:03

Yannickescu

Re: Yannick's work

#1089

Home away from home

Mazze added these to ports some months ago.
I'll upload tonight versions that should correct the image issue under BE systems.

@Wawa, can you tell me where you've seen the warning about indentation?

Posted on: 2018/7/25 6:42

Yannick
http://www.dusabledanslherbe.eu/AROSPage

nikolaos

Re: Yannick's work

#1088

Home away from home

Wawa: Have you compiled Zuneview and Zunepaint for abi v.1 that is possible to download?

I tried to contact Mazze for updating but he did not answer yet.

Maybe you could update Milkytracker there also?

https://trac.aros.org/trac/browser/AROS/trunk/ports?order=name

Posted on: 2018/7/24 21:49

www.aspireos.com

wawa

Re: Yannick's work

#1087

Home away from home

Quote:

Yannickescu wrote:
I've just checked again for mcc_Pictdisp and you are right, next release shall have it corrected.

great, there is just one warning about misleading indentation, but otherwise the source seems to be in a perfect state;)

you might want to check zunepaint source fo two other errors:
Quote:

diff -Naur New/ZunePaint/src/Win_GradDef.c ZunePaint_v0.13/ZunePaint/src/Win_GradDef.c
--- New/ZunePaint/src/Win_GradDef.c 2017-03-25 17:20:22.000000000 +0100
+++ ZunePaint_v0.13/ZunePaint/src/Win_GradDef.c 2018-07-21 16:30:08.817818052 +0200
@@ -25,7 +25,7 @@
#include "Picture_Paint.h"
#include "Picture_GradientFill.h"
#include "mcc_GradEdit.h"
-#include "mcc_graddisp.h"
+#include "mcc_Graddisp.h"
#include "Picture_Color.h"
#include "locale.h"

diff -Naur New/ZunePaint/src/ZunePaint.c ZunePaint_v0.13/ZunePaint/src/ZunePaint.c
--- New/ZunePaint/src/ZunePaint.c 2018-04-15 08:27:44.000000000 +0200
+++ ZunePaint_v0.13/ZunePaint/src/ZunePaint.c 2018-07-21 16:28:36.421855832 +0200
@@ -39,7 +39,7 @@
#include "SupportFunctions.h"
#include "mcc_Pictdisp.h"
#include "mcc_ScrollerPict.h"
-#include "mcc_HistDisp.h"
+#include "mcc_Histdisp.h"
#include "mcc_Matrix.h"
#include "locale.h"
#include "Picture_Geometry.h"

Quote:

When you say i386 what do you mean?
I release usually for i386_ABIv0 but you could also add it to port.
For others yes of course you can go, ABIv1 x86_64b should be added also

your software was added to ports by someone else (mazze?), i only updated the ports. but i might also add the rest of your tools, as it might be handy for those who want to run aros on anoher platform than i386 abi v0. i currently only compile abi v1.

Posted on: 2018/7/22 9:09

Yannickescu

Re: Yannick's work

#1086

Home away from home

I've just checked again for mcc_Pictdisp and you are right, next release shall have it corrected.

When you say i386 what do you mean?
I release usually for i386_ABIv0 but you could also add it to port.
For others yes of course you can go, ABIv1 x86_64b should be added also

Posted on: 2018/7/22 6:21

Yannick
http://www.dusabledanslherbe.eu/AROSPage