@caveman

Thanks that worked.

Jeff

GetBitMapAttr() seems cleaner; I'm not sure how future proof (or present proof ) the latter technique is.

looked at it again and it appears that stuff like:
Quote:
i quick fixed with:
Quote:
is probably simply properly replaced with:
Quote:

..ehrrm.... or rather:
Quote:

sorry..

Quote:

I don't know about the symbol, but I should have added that ABIv0 has already switched away from device-based handlers a few years ago (around the time of Icaros 2.0 IIRC). There wasn't a huge compatibility issue with the switch as few programs use that low-level functionality. So there is no difference between ABIv0 and ABIv1 in this regard.

Quote:

i guess the obsolete aros code could be guarded by
#if defined(__AROS__) && !defined(AROS_ABI_V1)
for the time abiv0 is still in circulation? does the latter be defined automatically when compiling abi v1?

Quote:

BnP did not open for me until I deleted the BarsnPipes.prefs file. Then it displayed a message that no valid prefs file was found. I clicked 'Ok' and then it asked me to choose a screen mode. After that it opened normally.

Later I went to the menu and selected preferences/enviornment and saved a new prefs file. It seemed to open fine after that.

Not my cup of tea, and I don't have a synth, so I did not try to do more. But it still returns an unfreed signal after exiting, if started from the shell.

@wawa

1. IIRC a decision was made to deprecate Screen->BitMap for ABIv1. It should remain binary compatible for m68k though. Access to the bitmap should be made through certain system functions instead of directly.

2. It looks like a change was made from the original Amiga sources to work with AROS's obsolete device-based handlers. It's likely the original code (under #else) will work there now, but this may need some changes to BSTR handling.

@hitchhikr
okay, i added a gui subdir copy section to makefile and my compile of bnp starts now alright on abiv1 i386 linux hosted.

do you accept proposals for patches or contributions to your source?

my idea is to add bars and pipes to ports section of aros source. the source would then be fetched from your server and built with aros toolchain on demand (not daily).

the advantage is it could be easier built automatically and maintained for different aros targets. i assume you are compiling so far only for abiv0 i386. it might be made ready for x64, m68k and so on.
---------------
for the time being i have few more detailed questions:

1.does "Screen->BitMap. .." currently compile for abiv0?
i had to replace all its occurences with "Screen->BitMap_OBSOLETE. .." here.

2. in BnP_files.c i disabled practically the whole files_getvolumes function(within __AROS__ ifdef).
it seems to either be broken or abiv0 specific. in particular:
strcpy(volume->name, dlist->dol_Ext.dol_AROS.dol_DevName);

3. as i said, there is a load of warnings gcc-6.3.0 paranoia issues over the code, i could try to look into it and propose for your review.

4. if bnp was to be included into ports, it might be beneficial to have data contained in the source in order to avoid anoother downlad, but it isnt a request or even that important. just a thought.

ah, okay, its you. very good;)

There's 2 zips:

http://franck.charlet.pagesperso-orange.fr/bnp.i386-aros.zip

and

http://franck.charlet.pagesperso-orange.fr/bnp.i386-aros-src.zip

the iffs are in the first one.

I'm not aware of a french author (beside me), any link ?